Added the ability to set custom actions on an alert.

logicalparadox / apnagent

Node.js adapter for Apple Push Notification (APN) Service.

http://logicalparadox.github.io/apnagent

216 stars 38 forks source link

Added the ability to set custom actions on an alert. #32

Closed ExploreMqt closed 9 years ago

ExploreMqt commented 9 years ago

Good call on the use of Array.isArray() thanks. Still learning JS.

ExploreMqt commented 9 years ago

The failure is totally unrelated to the changes made. I have however seen that same test fail one time locally. I've looked at the test and I'm not sure why it behaves unpredictably. Thoughts?

logicalparadox commented 9 years ago

Cache#push has an optional third argument for age, which is a timestamp. Looks like the test that is failing is not including the now variable, so the timestamp doesn't match if it took more than 1ms to push all four entries into the cache.

logicalparadox commented 9 years ago

LGTM: ready to merge?

ExploreMqt commented 9 years ago

I think so.