search

logicguy1 / FOSS-Lectio-improvements

A free and open source addon for Lectio
GNU General Public License v3.0
3 stars 1 forks source link

Show waiting assignments #8

Open Aech27 opened 1 year ago

Aech27 commented 1 year ago

A button like "Skjul afleveret opgaver", that shows returned assignments.

logicguy1 commented 1 year ago

Maybe it would be better to add it as the default behavior? Maybe we should change it so that the function that creates the buttons takes a function that gets called on every row and then returns true or false to wheater or not to hide that row, would allow for more complex functionalaty VS the current setup with only text filters being supported

logicguy1 commented 1 year ago

Or maybe add a filter for the row called Afventer

logicguy1 commented 1 year ago

Added in 34e2406 however there is a small issue with adding multiple filters and overwriting old filters

Reikimann commented 1 year ago

Added in 34e2406 however there is a small issue with adding multiple filters and overwriting old filters

Yeah. Toggling hideWaiting button, when hideDelivered is on. Delivered assignments is shown. I see two possibilities:

  1. Maybe decoupling the hideWaiting function from createAssingmentField.
  2. Add a new param to the createAssingmentField to ignore certain toggles when other toggles is on.
Reikimann commented 1 year ago

image

After loading the site, delivered assignments are shown even if they are toggled of (as can be seen on the picture).

@logicguy1 I suggest that we remove this toggle for now. This feature shouldn't be shipped to the users until it works properly. See PR #23