logicminds / bmclib

Puppet type for controlling the bmc as well as other useful facts
GNU Lesser General Public License v2.1
16 stars 12 forks source link

Error message on pupet 3.7.2 #23

Closed faxm0dem closed 9 years ago

faxm0dem commented 9 years ago

For the following manifest:

class { 'bmclib':}

bmc { 'ipmidevice':
  ensure => present,
  provider => 'ipmitool',
}

I'm getting the following error message:

Error: Could not prefetch bmc provider 'ipmitool': undefined method `find' for #<Puppet::Type::Bmc::ProviderIpmitool:0x7facad506750>

This is on EL6 using puppet 3.7

logicminds commented 9 years ago

Thanks for reporting. I assume you do have an ipmi device on that system. At any rate the error message should be better.

faxm0dem commented 9 years ago

I implemented some freeipmi code (provider and facts) and dropped this prefetch code because of this.

What does it do?

logicminds commented 9 years ago

yea, I see the erorr with prefetch and bad data coming through. Easy fix. Can you send a PR for your provider and facts. That would be awesome to add.

faxm0dem commented 9 years ago

Sure thing but before merging it would benefit from some code deduplication

logicminds commented 9 years ago

fixed in master branch