search

logicminds / rubyipmi

Command line wrapper for ipmitool and freeipmi
GNU Lesser General Public License v2.1
35 stars 32 forks source link

Discussion on ruby19 compatible #11

Closed crhan closed 10 years ago

crhan commented 11 years ago
  1. jeweler is completely not compatible with ruby19 cause it use rcov by default and rewrite gemspec file on every release workflow
  2. You do not have to make backward compatible like jeweler does(It ever support Gem under 1.2?) Yeah~ It's nearly 2014
  3. require 'bundler/gem_tasks' in your rake file and you will have some great tasks for build, install and release

Have a look at this: http://bundler.io/v1.3/rubygems.html

I'm still working on this branch, discussion is welcome

PS: and yes. these code is compatible with ruby19, but not the development gems.

crhan commented 11 years ago

It's now compatible with ruby18 to ruby20(Travis report the same failed number in ruby18 -> ruby20)

And I fixed some spec in ipmitool version (I'm not familiar with freeipmi)

crhan commented 11 years ago

sorry, that messy message is from some rebase work. Fixed in my repo

crhan commented 11 years ago

CI passed with ruby18, ruby19, and ruby20. and the last commit may need some review. cause I'm not familiar with freeipmi

sodabrew commented 10 years ago

I just started using Ruby IPMI with TheForeman. This PR looks great, hope to see it upstream soon! Good riddance to Jeweler. Nothing is hard about Rubygems anymore that requires another layer on top of it.

Update: I reviewed all of the changes in this PR, and just have the two comments about @crhan email address in the .travis.yml, and wondering what was going on with the change in the number of required arguments in 1c2d6aa.

logicminds commented 10 years ago

I am slammed with work at the moment. The freeipmi integration tests are failing which I can't run in travis (only at home), once the tests pass I can look at this merge request. Hoping to release 0.7 soon though.

Corey On Oct 7, 2013, at 4:53 PM, Aaron Stone notifications@github.com wrote:

I just started using Ruby IPMI with TheForeman. This PR looks great, hope to see it upstream soon!

— Reply to this email directly or view it on GitHub.

crhan commented 10 years ago

ruby19 seems like passed in travisCI. So close