search

logicminds / rubyipmi

Command line wrapper for ipmitool and freeipmi
GNU Lesser General Public License v2.1
35 stars 32 forks source link

Change #find_fix to try a different driver #28

Closed bdunne closed 7 years ago

bdunne commented 9 years ago

New PR against development branch + rebased. Based on https://github.com/logicminds/rubyipmi/pull/27

bdunne commented 9 years ago

@logicminds Did I understand correctly that you wanted the changes rebased against here?

logicminds commented 9 years ago

looks good thanks.

bdunne commented 9 years ago

@logicminds Do you want me to change anything else in this PR?

bdunne commented 9 years ago

@logicminds What are your thoughts on this change?

logicminds commented 9 years ago

I guess I am not totally sold on the refactor. The code really just implements the driver logic and I really want the find_fix feature to offer more than just driver replacements. If you were to pass in the 1.5 driver it would work for you, as well as your 2.0 devices too since the find_fix feature would fail over to the 2.0 driver. Send me the exact error messages and I can incorporate them into the error codes (or you can do this yourself too)