search

logicminds / rubyipmi

Command line wrapper for ipmitool and freeipmi
GNU Lesser General Public License v2.1
35 stars 32 forks source link

Add rubocop and correct most issues. #29

Closed bdunne closed 8 years ago

bdunne commented 8 years ago

Cleaning up some white space inconsistency

bdunne commented 8 years ago

@logicminds Please review

logicminds commented 8 years ago

can you stick a rubocop file in this PR so we can catch these easier next time.

bdunne commented 8 years ago

@logicminds I added a .rubocop.yml and cleaned up a bunch of other complaints. There are a few things left to do, but they are much larger changes than I intended to implement here, so I marked them as TODO in the yml and can revisit them in followup PRs.

It is much easier to review the changes when they are broken out by commit, so that's what I did here. Let me know and I can squash them before merge if you don't want that much noise in the git history.

bdunne commented 8 years ago

@logicminds Thanks!