search

logicminds / rubyipmi

Command line wrapper for ipmitool and freeipmi
GNU Lesser General Public License v2.1
35 stars 32 forks source link

Fix infinite loop when executing 'lan print' command #48

Closed mateusz-gozdek-sociomantic closed 6 years ago

mateusz-gozdek-sociomantic commented 6 years ago

The retrycount counter is currently not incremented, so in the situation when this command fails, library enters infinite loop of executing this command, which is bad.

This commit adds missing counter incrementation with the same style as in basecommands and make it return current @info in case of a faliure, so all methods accessing it will just get return nil.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8c101921d2c5ac47f3077c6a0139f3fc1f8bb869 on mateusz-gozdek-sociomantic:fix-lan-print-infinite-loop into 5afa8097ad7895ab792a764bdddc9b97d5b78724 on logicminds:master.

logicminds commented 6 years ago

Thanks for fixing this.