search

logicminds / rubyipmi

Command line wrapper for ipmitool and freeipmi
GNU Lesser General Public License v2.1
35 stars 32 forks source link

Simplify Github Actions definition #57

Closed ekohl closed 2 years ago

ekohl commented 2 years ago

This was copied from a repository where COVERAGE as an environment variable actually affected things. Here it doesn't so this keeps the action definition easier.

ekohl commented 2 years ago

This PR now also names the file so the tests actually run. However, for new workflows to run it needs to be in the repository. The workaround is pushing this branch to it once. That should trigger the tests. You can delete it afterwards.

ekohl commented 2 years ago

Looks like Ruby 3.0 actually doesn't work. Potentially just because of the way tests are written (you can't mock $CHILD_STATUS anymore). That's why I suggested (twice) to actually run the tests before merging.

lzap commented 2 years ago

I felt like 3.0 is still TODO and we would just waive it failing. Test: https://github.com/logicminds/rubyipmi/pull/59