search

logicomacorp / WaveSabre

Official WaveSabre repository
MIT License
246 stars 34 forks source link

Ignore deprecated functions in VSTSDK code #33

Closed kusma closed 4 years ago

kusma commented 4 years ago

We don't control the code in the VSTSDK, so the best thing we can really do there is to just ignore the warnings.

It's not like this is a big deal anyway; Microsoft never really removes anything in practice. But even if they would do, we would notice due to build-errors. And then we could either apply a patch before we we compile, or inject some macros to remap the functions. But for now, let's keep this simple.

This seems to make the current CI run warning-free as of writing.

Due to touching the VSTSDK source-files, this PR conflicts with #32. It's easy to resolve, though, and either can easily be rebased on the other. Just worth noting ;)

kusma commented 4 years ago

@yupferris: Hmpf, this isn't working on top of #32, as I pointed out in the initial cover-letter, it needs an update to the new path.