search

logicomacorp / WaveSabre

Official WaveSabre repository
MIT License
246 stars 34 forks source link

appveyor: also build MinSizeRel configuration #42

Closed kusma closed 4 years ago

kusma commented 4 years ago

The MinSizeRel configuration is both quite important, and somewhat fragile. So we should make sure we don't regress the build here.

We could also split this into a build-matrix entry, to compile both in parallel, but I figured that at 2m per build vs two times 1m 15sec, it's not really worth dealing with... What do you think?

kusma commented 4 years ago

Just to be clear, it seems that with the free tier of Appveyor, we don't get parallel builds anyway. So we might actually lose time by splitting this out. Not sure if that's true or just bad luck from my attempts, though. So yeah, maybe it'd be worse, maybe it'd be better.

yupferris commented 4 years ago

I think it's nice to have parallel builds but it's certainly worth accepting them in serial if it's only a couple of minutes anyways. Even as that grows by 2-8x it's not that painful really. So I want as many configurations as we can get!

yupferris commented 4 years ago

Re-reading your comments, I think we should not split it out if you don't seem to have any luck with the free tier so far anyways, and accept/merge this as-is.

kusma commented 4 years ago

@yupferris: Sounds good to me. So I guess we can just merge?

yupferris commented 4 years ago

Yep!