WIP: cmake: default to x86 builds on newer VS versions

logicomacorp / WaveSabre

Official WaveSabre repository

MIT License

247 stars 34 forks source link

WIP: cmake: default to x86 builds on newer VS versions #56

Closed kusma closed 4 years ago

kusma commented 4 years ago

WaveSabre is mainly an x86 project, and up until CMake 3.14 it always picked the Win32 target for MSVC projects. But in version 3.14 this changed when the VS 2019 generator was added, which picks x64 by default on x64 machines.

So let's override that, so we compile x86 code by default. It's what most users are going to want.

kusma commented 4 years ago

I haven't really tested this properly, because I don't have CMake 3.14 installed at the moment. Perhaps @armak can test this?

armak commented 4 years ago

Doesn't work with CMake version 3.14.3. With -A Win32 flag it does but by just invoking with cmake -B build it only generates x64 configuration for VS 2019.

kusma commented 4 years ago

OK, back to the drawing-board, then ;)

kusma commented 4 years ago

I can't find a reasonable way of doing this, sadly :(