search

logicomacorp / WaveSabre

Official WaveSabre repository
MIT License
245 stars 33 forks source link

CI: Specify multiple VS images #78

Closed yupferris closed 3 years ago

yupferris commented 3 years ago

All of these appear to work with the current codebase, and it would be nice to keep it that way, so let's build all of them in CI, too. Especially for the latest version (2019 at the time of writing), having CI coverage is very important.

Fixes #77.

yupferris commented 3 years ago

So it seems 2013, 2017, and 2019 all build without issues, and 2015 seems to have some missing symbols (details here). I have no intention of fixing these issues, especially for older VS versions, so I think the right move for now is to just remove it from the list (effectively only officially support the other 3) and make a separate issue for it, and someone else can fix it if they want to. Frankly I think nobody using WS actually cares about anything other than VS 2019 anyways (or later versions in the future), so we should be good.

yupferris commented 3 years ago

Spawned #79.