logicomacorp / WaveSabre

Official WaveSabre repository
MIT License
247 stars 34 forks source link

Fix parsing problems with FL Studio 20.9 project files. #98

Open LeStahL opened 2 years ago

LeStahL commented 2 years ago

Removed the Monad FL Parser binary from the repository. Added opt-in auto-download and default path override options for the FL parser to CMakeLists.txt. Changed referenced Monad FL parser version to be able to parse FL 20.9 project files.

Implements #97.

LeStahL commented 2 years ago

After using the code in this PR for a while, I have mixed feelings about this PR: I should remove the externalproject mechanism. It's unreliable. I'd prefer a FLParser git submodule containing the CMakeLists.txt and the 20.9 FLP fix as commit. Maybe as logicomacorp fork of the original FLParser (it's unmaintained atm)? The FLParser dll should not be in the tree imo (it's GPL). Also, this PR should be several PRs, as it's addressing multiple things at once.