login-securite / DonPAPI

Dumping DPAPI credz remotely
GNU General Public License v3.0
941 stars 112 forks source link

VNC plugin error on reading and parsing registry key #10

Closed Th3l5D closed 2 years ago

Th3l5D commented 2 years ago

The VNC plugin in software/sysadmin/vnc.py does not handle properly the read of a registry key.

There is two issues:

Th3l5D commented 2 years ago

Will send a PR with a fix (tested only on thightVNC on a single asset) in a second if I understand how it works :D

Edit : PR sent. Please note that I fixed the issue and removed the (now useless) unhex method. I did NOT rewrote any part of the code to be more readable.

login-securite commented 2 years ago

Thanks ;-)