login-securite / DonPAPI

Dumping DPAPI credz remotely
GNU General Public License v3.0
930 stars 110 forks source link

HTML report (-R) markup inconsistency & optimization #55

Closed Zeecka closed 1 month ago

Zeecka commented 1 year ago

HTML reports have inconsistency (missing closing markup, no coherence with lowercase/uppercase, ...) and can be optimized (for instance: <a class="firstletter">H</a><a>ostname</A> can be replaced with <p>Hostname</p> using the CSS selector ::first-letter).

I'd like to work on the generate_report() function, using Jinja templating. Is it worth having a try and are you looking for a PR on this feature (report content won't change, only a refactoring) ?

zblurx commented 1 year ago

Hey, it would be great 😁

Zeecka commented 1 year ago

I'm currently working on refactoring database.py (PEP-8 compliant, ...), then I'll start reworking on the HTML rendering. I do not have an exhaustive lab to test DonPAPI. Can you provide a VM or better, a sqlite3 database with credentials so I can interface with ?

zblurx commented 1 year ago

Actually I do not have an exhaustive lab either, as DonPAPI is collecting a looot of stuff.

zblurx commented 1 month ago

Closing since no report anymore