search

logisim-evolution / logisim-evolution

Digital logic design tool and simulator
GNU General Public License v3.0
4.76k stars 616 forks source link

nios ii branch issue #1758

Closed halvbanan closed 1 year ago

halvbanan commented 1 year ago

when branching to a label it jumps to the location but it negates the pc addition so it minuses when its ahead and plusses when its behind the branch

maehne commented 1 year ago

Thanks for the report @halvbanan! Could you please provide a reproducer (ZIP archive with .circ file plus assembly/ELF file) demonstrating the issue?

halvbanan commented 1 year ago

branchtest.zip here, it just branches ahead of target and behind target, it should be a nop-branch but it executes a branch-branch

maehne commented 1 year ago

Thanks for the reproducer @halvbanan! @BFH-ktt1: Could you please have a look, as you wrote that code?

BFH-ktt1 commented 1 year ago

@halvbanan : Thanks a lot for this bug report. I can reproduce your problem and will look into a solution

BFH-ktt1 commented 1 year ago

@halvbanan : The problem should be fixed by my latest PR. Closing this issue as resolved, please reopen if there is still a problem.

halvbanan commented 1 year ago

still is not fixed on the msi version, i redownloaded the latest version of x86-msi and ran the test that i gave on the zip folder, still does a branch-branch loop instead of branch-nop .

davidhutchens commented 1 year ago

@halvbanan: You used the last release build. @BFH-ktt1 meant to say that the problem is fixed in our develop branch.

You can find the nightly build here: https://github.com/logisim-evolution/logisim-evolution/actions/workflows/nightly.yml

For Windows, use the .msi artifact in the latest nightly build.