Closed hwijeen closed 10 months ago
Just a random thought, in a similar way, could LoRA's ekfac lambda also be computed analytically if we have the original ekfac lambda?
seems not, it's not useful anyways
@sangkeun00 Iirc, you mentioned that this PR needs to be readressed once you finish refactoring / LoRAEmbedding. Can you confirm that it's still the case? If so, I will close this PR and make another PR about small things (the issue with inplace opeartion, ...)
closing as outdated
Previously, Analog consumed one epoch to collect 'LoRA covariances' (covariances with the compressed activations). This PR computes the same quantity analytically, using the projection matrix.
This includes hacky patches, we might need to reconsider how we do
finalize
,clear
, ...I confirmed that the analytical way produces the same covariances and the same influence score.