logix-project / logix

AI Logging for Interpretability and Explainability🔬
Apache License 2.0
74 stars 6 forks source link

analog.eval() doesn't turn on grad=True #75

Closed hage1005 closed 8 months ago

hage1005 commented 8 months ago

Currently eval() turns off save and statistics, maybe it should also turn on grad? Currently grad won't be turned on unless training phase happened.

sangkeun00 commented 8 months ago

This is an intended behavior as users may want to use different logs than "grad" in their application, but I think it's probably good to have an additional argument of log in eval. For example, we can let users do something like:

analog.eval(log="grad")

For now, as you suggested, we can set the default value of log to "grad".