add requirements and fix minor bug in gpt2 example

logix-project / logix

AI Logging for Interpretability and Explainability🔬

Apache License 2.0

74 stars 6 forks source link

add requirements and fix minor bug in gpt2 example #88

Closed LauraRuis closed 7 months ago

LauraRuis commented 7 months ago

Just adding some requirements needed for running wiki example + fix a minor bug in train.py

sangkeun00 commented 7 months ago

Hi Laura,

Thanks for fixing the bug in our GPT training code. Regarding the requirements, dependencies like transformers and accelerate are specific to some examples (e.g. BERT, GPT), but not to analog itself. Therefore, I am inclined to include these dependencies in a separate requirements.txt in each example directory. Any thoughts?

eatpk commented 7 months ago

I've tried to address this problem here, PTAL! https://github.com/sangkeun00/analog/pull/89

sangkeun00 commented 7 months ago

Fixed in 21a51683d0a91afc4efe0bf569c2c5c655ab528c