logix-project / logix

AI Logging for Interpretability and Explainability🔬
Apache License 2.0
74 stars 6 forks source link

Metadata loading bug #91

Closed sangkeun00 closed 7 months ago

sangkeun00 commented 7 months ago

Since PR #87, metadata is supposed to have only one entry per data_id. However, in the presence of data duplication, which is pretty common in real-world ML, there may also be duplicate data_id in metadata. This causes an error in the below code:

https://github.com/sangkeun00/analog/blob/21a51683d0a91afc4efe0bf569c2c5c655ab528c/analog/logging/log_loader_util.py#L71

@eatpk Can you look into this bug? My guess is that we can simply remove this if statement and simply override it for data with same id.

eatpk commented 7 months ago

https://github.com/sangkeun00/analog/pull/92 PTAL!