search

logological / gpp

GPP, a generic preprocessor
https://logological.org/gpp
GNU Lesser General Public License v3.0
197 stars 31 forks source link

There is no INSTALL file #38

Closed drj11 closed 4 years ago

drj11 commented 4 years ago

Per my review at https://github.com/openjournals/joss-reviews/issues/2400

For installation your README says "see the included INSTALL file." but there is no INSTALL file.

logological commented 4 years ago

The INSTALL file is automatically generated by the GNU Autotools when they produce the portable source packages. As a generated file, it is not checked into the source repository. If you download the portable source packages, you can verify that the file exists there.

drj11 commented 4 years ago

Yes, that is what I'm doing now. In which case that's fine for the purposes of review, but I would encourage you to mention this fact in the README. The README does mention that you can clone the github repo, but perhaps it should not. Or it should say that cloning is only recommended for developers or people willing to get familiar with autotools.

logological commented 4 years ago

OK, I will make the README a bit more explicit in this respect.