search

logos-co / nomos-node

Nomos blockchain node
38 stars 13 forks source link

DA API Payload to Item in mempool #634

Closed bacv closed 2 months ago

bacv commented 2 months ago

Payload to Item conversion when appending to the mempool. This change aims to support da certificate conversion into VID and insertion into a mempool. Receive Certificate as payload, insert VID as item.

bacv commented 2 months ago

@danielSanchezQ @youngjoon-lee @zeegomo Marking PR as ready to be reviewed and merged into da-protocol-v1 branch.

The main objective of this PR was to allow da mempool receive a Certificate via the network and covert it to VID when adding to the item pool. Certificate verification will be added in other PR.

danielSanchezQ commented 2 months ago

Nice to see tests green again!!! 🚀

bacv commented 2 months ago

I may be misslead for the (probably) unupdated PR title. But I cannot locate where does the verification happens (in the da mempool?).

I've updated the PR description, at the moment code focuses on the conversion; Verification will be added in the next PR.