search

logos-co / nomos-node

Nomos blockchain node
52 stars 18 forks source link

Da: Network sampling #689

Closed danielSanchezQ closed 3 months ago

danielSanchezQ commented 3 months ago

Need of #688 to be merged first.

danielSanchezQ commented 3 months ago

@romanzac More stuff on DA networking (libp2p) here.

romanzac commented 3 months ago

@romanzac More stuff on DA networking (libp2p) here.

I'll have more time to go through the code next week. libp2p is used for all types of messaging - consensus, da, ?

danielSanchezQ commented 3 months ago

@romanzac More stuff on DA networking (libp2p) here.

I'll have more time to go through the code next week. libp2p is used for all types of messaging - consensus, da, ?

Yes, everything uses libp2p, although DA is probably the one that goes deeper in the stack.

romanzac commented 3 months ago

Hi, @danielSanchezQ I have a question about maximum subnet size. We were talking about 4096. I haven't seen any check on number of members in the implementations of trait MembershipHandler. It is kind of a restriction, so perhaps it will be added later ?

danielSanchezQ commented 3 months ago

Hi, @danielSanchezQ I have a question about maximum subnet size. We were talking about 4096. I haven't seen any check on number of members in the implementations of trait MembershipHandler. It is kind of a restriction, so perhaps it will be added later ?

4096 is a theoretical limit (because of current hardware encoding times). We probably gonna go with just 2048 subnets for now. This is gonna be a configuration that should be in one of the upper layers (tbd). Or even in the final implementation of the MembershipHandler. I can ping you to the the code once its done :smiley: