search

logos-co / nomos-specs

Nomos related specification and documentation
2 stars 2 forks source link

cryptarchia: fix try_create_fork to find parent block #84

Closed youngjoon-lee closed 6 months ago

youngjoon-lee commented 6 months ago

It seems that we should find the position of the "parent" of the block to be added when trying to create a fork, but the current implementation finds the position of the "block" to be added.

Please correct me if I'm wrong.

youngjoon-lee commented 6 months ago

Do you want to add a test to verify that forks are created correctly?

Sure. I'll add tests in this PR soon and re-request your review!

zeegomo commented 6 months ago

Good catch, concerning that it was not caught by tests