search

logos-co / staking

SNT Staking contracts
Creative Commons Zero v1.0 Universal
0 stars 4 forks source link

fix(StakeManager): use OpenZeppelin Math to avoid precision loss in int divisions #66

Closed 3esmit closed 8 months ago

3esmit commented 8 months ago

Description

Alternative to #67; This PR fixes #64 and Fixes #24

Checklist

Ensure you completed all of the steps below before submitting your pull request:

3esmit commented 8 months ago

@0x-r4bbit Do you have any idea why lint is failing?

image

36191276-5bc817c0-116d-11e8-89cb-b5c96c054936

forge --version forge 0.2.0 (ac80261 2024-02-24T00:17:06.154246094Z)

3esmit commented 8 months ago

The lint error is caused by this commit https://github.com/logos-co/staking/pull/66/commits/d7be979f0e37ca71faa982a7c2420421ce380c0e as shown in https://github.com/vacp2p/foundry-template/pull/18

3esmit commented 8 months ago

I found the error in lint, was a stupid EOF from Windows. I will now redo everything here.