After discussing this offline, we've decided that the naming of these properties was misleading. This commit performs the following changes:
account.initialMP becomes account.bonusMP
account.currentMP becomes account.totalMP
Rationale:
initialMP indicates that this is an immutable field which is not the case as in scenarios where accounts increase the lock() time, they'll also increase their bonus multiplier (initialMP).
currentMP was misleading in combination with initialMP. Really what it reflects is the total multiplier points of an account including its bonus multiplier points.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
After discussing this offline, we've decided that the naming of these properties was misleading. This commit performs the following changes:
account.initialMPbecomesaccount.bonusMPaccount.currentMPbecomesaccount.totalMPRationale:
initialMPindicates that this is an immutable field which is not the case as in scenarios where accounts increase thelock()time, they'll also increase their bonus multiplier (initialMP).currentMPwas misleading in combination withinitialMP. Really what it reflects is the total multiplier points of an account including its bonus multiplier points.Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm gas-report?pnpm lint?forge test?pnpm verify?