ci: publish releases to IPFS

logos-innovation-lab / Kurate

https://kurate.vercel.app/

1 stars 4 forks source link

ci: publish releases to IPFS #201

Closed filoozom closed 1 year ago

filoozom commented 1 year ago

Some notes:

I used npm ci as IIRC the issue only happens with hardhat, which is not used to build the UI
I removed fetch-depth: 0 because I don't see why we would need that (should also be removed from the check workflow I think?)
It uses a node I run because it's necessary to be able to sign IPNS records

I'm not sure if npm ci is enough to build the project at this stage, but as far as I can tell download:snark-artifacts is only for contracts and npx playwright install just for testing?

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
kurate	✅ Ready (Inspect)	Visit Preview	Feb 15, 2023 at 8:51PM (UTC)

filoozom commented 1 year ago

What fetch-depth: 0 means is that it just checks out the latest version of the code without fetching all the past commits and other branches. It really just reduces the amount of data you need to fetch so I would keep it.

Well, it's actually the exact contrary of that. fetch-depth: 0 specifically downloads everything, not just the latest commit. Source: https://github.com/actions/checkout.

Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags. Refer here to learn which commit $GITHUB_SHA points to for different events.

vojtechsimetka commented 1 year ago

You are correct, thank you very much for pointing it out!