search

logpresso / CVE-2021-44228-Scanner

Vulnerability scanner and mitigation patch for Log4j2 CVE-2021-44228
Apache License 2.0
851 stars 174 forks source link

Customize backup extension name #141

Closed strawgate closed 2 years ago

strawgate commented 2 years ago

We want to use the presence of a backed up jar file to know that it has been remediated already via other tools. The problem is .bak is a ubiquitous extension and may not actually indicate the jar next to it was remediated, it could have been created for any reason. Allowing customization would allow for us to save the backup file as something like .log4j.bak

jgstew commented 2 years ago

I agree, that makes sense. Or maybe even .log4jscan.bak?

xeraph commented 2 years ago

I'm considering backing up all files in one ZIP file for convenience.

strawgate commented 2 years ago

I think that would have the opposite impact and would make identifying which jar to restore more difficult so hopefully that would be optional?

xeraph commented 2 years ago

Sure :D

xeraph commented 2 years ago

@strawgate Would you test v2.5.0 release? You don't have to think about file extension. :D

xeraph commented 2 years ago

@strawgate --backup-ext option is added in v2.5.2. Would you try it?