search

logsB06 / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #2

Open farishkash opened 6 years ago

farishkash commented 6 years ago

Overall met expectations

In this first project, I look at two primary items with the main goal being to stop inefficient or bad practices early.

First, did you use divs, ids/classes to manage and organize your HTML. Great on this, Your div and class/id organization had everything I look for. The main concern here is using the appropriate elements inside of other text elements such as span vs hyperlinks

Second is your CSS efficient and non-repetitive. Great on your CSS, you avoided the common mistakes that I usually see in this first project.

To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.

logsB06 commented 6 years ago

Thank you for the feedback! I will make sure to use the span element instead of the anchor element next time.