Open lucahowles opened 1 year ago
Attention: Patch coverage is 0%
with 37 lines
in your changes are missing coverage. Please review.
Project coverage is 87.38%. Comparing base (
59c6b8e
) to head (39b77f2
).
Files | Patch % | Lines |
---|---|---|
carmm/analyse/GCN.py | 0.00% | 37 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@GaryLZW What was the status of this? Can I ask for your review and merge actions? As I was hoping to pick this up with my future student?
@GaryLZW Any news on this pal?
@GaryLZW Any news on this pal?
Hi Andy. Sorry, I forgot about this for some time. I am not sure if I can make changes to Luca's code. I will probably open another branch and get this code into some usable form.
This is code to calculate the coordination number, then generalised coordination number of a structure. The slab size needs to be at least (5, 5, 5) to work for fcc110 so if anyone might know how to make that work with smaller slabs that would be great. Also, the code doesn't work with higher indices (so another point for improvement).