Closed logsdail closed 9 months ago
@ikowalec this one should take you seconds to review, please.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9dbac9d
) 86.27% compared to head (db81215
) 86.27%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I see, the os.environ
retrieves variables as string. The changes are self-explanatory, so happy for this to be merged.
[like] Andrew Logsdail reacted to your message:
From: Igor Kowalec @.> Sent: Wednesday, December 13, 2023 4:51:44 PM To: logsdail/carmm @.> Cc: Andrew Logsdail @.>; Author @.> Subject: Re: [logsdail/carmm] Type cast system scraped variables otherwise I get an incompatible op… (PR #136)
External email to Cardiff University - Take care when replying/opening attachments or links. Nid ebost mewnol o Brifysgol Caerdydd yw hwn - Cymerwch ofal wrth ateb/agor atodiadau neu ddolenni.
@ikowalec approved this pull request.
self-explanatory
— Reply to this email directly, view it on GitHubhttps://github.com/logsdail/carmm/pull/136#pullrequestreview-1780086421, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMK4MZJOT7GFEFNS35AXLDYJHMKBAVCNFSM6AAAAABATOWVXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBQGA4DMNBSGE. You are receiving this because you authored the thread.Message ID: @.***>
…eration for str/str on Hawk