logsdail / carmm

Scripts for creation, manipulation and analysis of geometric and electronic structure of molecular models
GNU General Public License v3.0
5 stars 17 forks source link

Type cast system scraped variables otherwise I get an incompatible op… #136

Closed logsdail closed 9 months ago

logsdail commented 9 months ago

…eration for str/str on Hawk

logsdail commented 9 months ago

@ikowalec this one should take you seconds to review, please.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9dbac9d) 86.27% compared to head (db81215) 86.27%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #136 +/- ## ======================================= Coverage 86.27% 86.27% ======================================= Files 70 70 Lines 2754 2754 ======================================= Hits 2376 2376 Misses 378 378 ``` | [Flag](https://app.codecov.io/gh/logsdail/carmm/pull/136/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/logsdail/carmm/pull/136/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail) | `86.27% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ikowalec commented 9 months ago

I see, the os.environ retrieves variables as string. The changes are self-explanatory, so happy for this to be merged.

logsdail commented 9 months ago

[like] Andrew Logsdail reacted to your message:


From: Igor Kowalec @.> Sent: Wednesday, December 13, 2023 4:51:44 PM To: logsdail/carmm @.> Cc: Andrew Logsdail @.>; Author @.> Subject: Re: [logsdail/carmm] Type cast system scraped variables otherwise I get an incompatible op… (PR #136)

External email to Cardiff University - Take care when replying/opening attachments or links. Nid ebost mewnol o Brifysgol Caerdydd yw hwn - Cymerwch ofal wrth ateb/agor atodiadau neu ddolenni.

@ikowalec approved this pull request.

self-explanatory

— Reply to this email directly, view it on GitHubhttps://github.com/logsdail/carmm/pull/136#pullrequestreview-1780086421, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMK4MZJOT7GFEFNS35AXLDYJHMKBAVCNFSM6AAAAABATOWVXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBQGA4DMNBSGE. You are receiving this because you authored the thread.Message ID: @.***>