logsdail / carmm

Scripts for creation, manipulation and analysis of geometric and electronic structure of molecular models
GNU General Public License v3.0
5 stars 17 forks source link

Remove redundant tools for mapping functions #145

Closed ikowalec closed 2 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.11%. Comparing base (0c474b8) to head (400581a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #145 +/- ## ========================================== + Coverage 88.35% 89.11% +0.75% ========================================== Files 82 81 -1 Lines 3316 3288 -28 ========================================== Hits 2930 2930 + Misses 386 358 -28 ``` | [Flag](https://app.codecov.io/gh/logsdail/carmm/pull/145/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/logsdail/carmm/pull/145/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail) | `89.11% <ø> (+0.75%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

logsdail commented 4 months ago

@ikowalec : Is this OK to merge?

logsdail commented 3 months ago

@ikowalec Is this still needed? Looks like it predates our work to get the docs working?

logsdail commented 3 months ago

@ikowalec Is this still needed? Looks like it predates our work to get the docs working?

^^ bump ^^

ikowalec commented 2 months ago

@ikowalec Is this still needed? Looks like it predates our work to get the docs working?

The branch needs updating and the redundant hacky files should still be removed. I will revert the change on the .yml file to avoid conflicts.