search

logsdail / carmm

Scripts for creation, manipulation and analysis of geometric and electronic structure of molecular models
GNU General Public License v3.0
5 stars 17 forks source link

Global variable changes to adsorbate placer GUI #147

Open GabrielBram opened 6 months ago

GabrielBram commented 6 months ago

This change wasn't committed properly at some point and now finally fixing it.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (4ed96da) to head (bb5f993). Report is 36 commits behind head on main.

Files Patch % Lines
carmm/build/adsorbate_placer_gui.py 25.00% 3 Missing :warning:
carmm/build/adsorbate_placer.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #147 +/- ## ========================================== + Coverage 88.23% 89.50% +1.26% ========================================== Files 80 82 +2 Lines 3265 3305 +40 ========================================== + Hits 2881 2958 +77 + Misses 384 347 -37 ``` | [Flag](https://app.codecov.io/gh/logsdail/carmm/pull/147/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/logsdail/carmm/pull/147/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail) | `89.50% <84.61%> (+1.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

robinsonmt1 commented 6 months ago

Wasn't committed previously because a required codecov test technically fails. Need to find a way to go around this requirement