search

logsdail / carmm

Scripts for creation, manipulation and analysis of geometric and electronic structure of molecular models
GNU General Public License v3.0
5 stars 17 forks source link

Hotfix updates to get newer python versions working 1 #164

Closed logsdail closed 3 months ago

logsdail commented 3 months ago

So efforts to resolve reasons we can't work with more recent Python versions. Should be quick to review.

logsdail commented 3 months ago

Added reviewers whose code I think has been touched.

logsdail commented 3 months ago

Please review asap so I can merge and then pull into the Python 3.8/9 branch.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.35%. Comparing base (59c6b8e) to head (8708095).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #164 +/- ## ======================================= Coverage 88.35% 88.35% ======================================= Files 82 82 Lines 3316 3316 ======================================= Hits 2930 2930 Misses 386 386 ``` | [Flag](https://app.codecov.io/gh/logsdail/carmm/pull/164/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/logsdail/carmm/pull/164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail) | `88.35% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Logsdail#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.