logsdail / carmm

Scripts for creation, manipulation and analysis of geometric and electronic structure of molecular models
GNU General Public License v3.0
5 stars 18 forks source link

Colormaps #82

Closed JackWarren23 closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #82 (8f74f39) into master (80ab681) will decrease coverage by 0.27%. The diff coverage is 54.16%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   84.07%   83.79%   -0.28%     
==========================================
  Files          63       65       +2     
  Lines        2562     2586      +24     
==========================================
+ Hits         2154     2167      +13     
- Misses        408      419      +11     
Flag Coverage Δ
unittests 83.79% <54.16%> (-0.28%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
carmm/analyse/colormaps.py 0.00% <0.00%> (ø)
examples/Build_colour_bars.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

logsdail commented 2 years ago

I'm really confused by your example @JackWarren23 , as it seems to duplicate code from the repository? Shouldn't you be calling the new function?

logsdail commented 2 years ago

Also, please can the test be setup to test the code, with an assertion (see other tests!) rather than just provide an example usage? The use example can be kept, but is second to the QA test and code coverage - this is necessary to stop the code being broken