logsearch / logsearch-boshrelease

A BOSH-scalable Elasticsearch+Logstash+Kibana release
http://www.logsearch.io
Apache License 2.0
57 stars 46 forks source link

Kibana plugins installation fix #215

Closed Infra-Red closed 8 years ago

Infra-Red commented 8 years ago

Hi , I create fix for kibana plugins installation. If you try to add plugins to deployment manifest current logsearch release will return nil value for plugin location:

undefined method `start_with?' for nil:NilClass

This behavior can be described with next example, here shows the correct and incorrect behaviour:

2.2.4 :001 > a,b = [1,2]
 => [1, 2]
2.2.4 :002 > a
 => 1
2.2.4 :003 > b
 => 2
2.2.4 :004 > a,b = [1,2].first
 => 1
2.2.4 :005 > a
 => 1
2.2.4 :006 > b
 => nil
2.2.4 :007 >
cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/115418821.

mrdavidlaing commented 8 years ago

@cromega - Good to merge from a PM / legal perspective

Infra-Red commented 8 years ago

I also added the fix for kibana environment variables. Next issue occurred during preparing of deployment :

Error 100: Error filling in template `kibana_ctl' for `kibana/0' (line 22: undefined method `keys' for ["CF_API_URL", "https://api.example.com"]:Array)
cromega commented 8 years ago

@Infra-Red: I'm terribly sorry, I forgot about this PR a bit.

What are you trying to fix exactly? We are using this release without issues with kibana plugins and env settings. Could you show me your kibana properties from your deployment manifest?