search

logsearch / logsearch-boshrelease

A BOSH-scalable Elasticsearch+Logstash+Kibana release
http://www.logsearch.io
Apache License 2.0
57 stars 46 forks source link

Drain cannot be disabled via the manifest #216

Closed adamstegman closed 8 years ago

adamstegman commented 8 years ago

It looks like a side effect of the fix for #209 was that it's no longer possible to set elasticsearch.drain to false. Was this intentional? If not, here's a quick PR to replace it.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/115638225.

cromega commented 8 years ago

@adamstegman: yes, it is intentional. Relying on a deployment property to turn the drain feature on and off is and has always been a broken mechanism.

Deploying with elasticsearch.drain: false does not actually turn off this feature, it just updates the drain script with an early exit 0.

Imagine you have the drain turned on but you actually want to deploy without it because something breaks because of it. First you would need to get a deploy through without problems in order to update the drain scripts with the new content.

Drain is supposed to be controlled via the appropriate BOSH cli flag:

bosh deploy --skip-drain elasticsearch_data