logsearch / logsearch-boshrelease

A BOSH-scalable Elasticsearch+Logstash+Kibana release
http://www.logsearch.io
Apache License 2.0
57 stars 46 forks source link

Make elasticsearch/drain less intelligent #71

Closed dpb587 closed 9 years ago

dpb587 commented 10 years ago

The elasticsearch drain script needs improvement. The recurring problem is that it's frequently told job_shutdown in cases where the disk data won't actually be changing (e.g. changing disk size, instance type, IP address) and it causes significant delays in what should otherwise be a quick process. I think the drain script should only/always block until the cluster is green. The case where you might be removing a node from the cluster is just causing complications and, as long as you have replicas, the simple green check can handle that scenario, just not in a preventive manner as originally intended.

Additionally, consider implementing and testing the following logic:

aristotelesneto commented 10 years ago

Sounds like a bug in BOSH worth reporting.

dpb587 commented 9 years ago

A simpler drain script was implemented in https://github.com/logsearch/logsearch-boshrelease/commit/da41135de44847efa7e5df719bea4ecacaea81e2