logsearch / logsearch-shipper-boshrelease

Forward the log messages and metrics that your BOSH jobs generate
Apache License 2.0
1 stars 5 forks source link

Drop the plugin. prefix from config #1

Closed mrdavidlaing closed 10 years ago

mrdavidlaing commented 10 years ago

I think we design the config as if this is a core BOSH feature (in the hope that we can make that happen)

Thus, rather than prefixing all properties with plugin.log., I think they should just be log.

eg:

properties:
  ...snip...
  logs:
    syslog:
      server: "192.0.2.1:5514"
dpb587 commented 10 years ago

I think properties should mirror the release and job names. I was using the plugin prefix in both to explicitly indicate it is something that runs alongside deployments rather than being part of the intended deployment. I thought the property prefix would avoid any conflicts and confusion with existing releases which may use their own logs.* properties.

With that being said, is it still something which should change?

dpb587 commented 10 years ago

We've switched to more of a logsearch prefix.