logsearch / workspace

Apache License 2.0
1 stars 1 forks source link

Remove local logsearch manifest.yml #11

Open dpb587 opened 9 years ago

dpb587 commented 9 years ago

Seems like we've committed a sample logsearch manifest.yml for logsearch-boshrelease. I don't think that's a good idea because then we'd have to maintain it in separate places (logsearch-boshrelease repo and here). In this case, v18 dropped collectd which this local manifest was including and caused unnecessary confusion.

Instead, I think we should be copying the examples/bosh.yml into the local directory, whether that's by cloning the repo or doing a wget to the raw file on github.

https://github.com/logsearch/workspace/blob/master/_setup/runtime/workspace_skel/environments/local/test/logsearch/manifest.yml

dpb587 commented 9 years ago

@mrdavidlaing, agreed?

mrdavidlaing commented 9 years ago

@dpb587, I've gone round in circles on this one a bit, since the /environments/local/test/logsearch/manifest.yml ended up becoming quite workspace specific. (Note how it makes use of some workspace specific environment variables, eg TENANT_NUMBER, and is configured to pull its filter config from https://github.com/logsearch/workspace/blob/master/_setup/runtime/workspace_skel/environments/local/test/logsearch/logsearch-for-weblogs/logsearch-for-weblogs.filters.conf)

If you think it still belongs in logsearch-boshrelease, lets move it there but give it a name indicating that it is for use in the logsearch workspace.

Thoughts?