search

logsem / iris-project

2 stars 18 forks source link

Logo sources + basic use of logo and favicon. #4

Closed rlepigre closed 3 years ago

rlepigre commented 3 years ago

Visual changes:

This also inlcudes:

page

robbertkrebbers commented 3 years ago

It seems you also added some other attempts at logos: logo-thin and logo-r. I am not sure what they are, but I would prefer not to add them here, since people might end up using a different version than the "official" one.

rlepigre commented 3 years ago

Yes, I added all the version of the logo that were in the other repository. However, I think it is good to have then all in one place, in case we want to update the logo in the future. Note that only the official SVG files are recorded in the repo, so you cannot really use the wrong logo by mistake. And if one wants to take a shot at designing a new logo then the infrastructure is there, they just have to create a new file in the iris-logo folder and change a variable in the Makefile.

robbertkrebbers commented 3 years ago

Then please add a big disclaimer in these logo files that they those are not the official logos, and should not be used.

rlepigre commented 3 years ago

Then please add a big disclaimer in these logo files that they those are not the official logos, and should not be used.

I changed a few things, I think the new file names should be enough of a disclaimer, what do you think?

robbertkrebbers commented 3 years ago

I think the new files names are clearer. Still, I think a comment in the file would not hurt, but up to you.

In my version of the stylesheet, I also updated the colors to better match the logo. Could you also include that?

RalfJung commented 3 years ago

On the chat someone said adding the new logo would make website even worse on mobile; is that still the case?

robbertkrebbers commented 3 years ago

On the chat someone said adding the new logo would make website even worse on mobile; is that still the case?

In my version https://robbertkrebbers.nl/iris-tmp/, I put the logo next to the buttons. This is nicer than what happens in this MR, but the way I implemented it does not work nicely on mobile. I don't know if the version in this MR displays nicely on mobile.

RalfJung commented 3 years ago

I checked with Firefox' "responsive design mode", and I'd say it's no worse than before.

rlepigre commented 3 years ago

I checked with Firefox' "responsive design mode", and I'd say it's no worse than before.

Yes, I check that on Chrome. The buttons are still horrible on mobile, but that is indeed no worse than before.

@robbertkrebbers I tired putting the logo next to the text as you did, but that indeed broke the mobile layout. For some reason I was not able to use the same trick as in my webpage. I guess we can revisit the layout later, this PR just aims at moving the logo here.

rlepigre commented 3 years ago

In my version of the stylesheet, I also updated the colors to better match the logo. Could you also include that?

OK, I took in the changes to the button colors.

robbertkrebbers commented 3 years ago

@robbertkrebbers I tired putting the logo next to the text as you did, but that indeed broke the mobile layout. For some reason I was not able to use the same trick as in my webpage. I guess we can revisit the layout later, this PR just aims at moving the logo here.

Fine to me. I think we want to improve the layout in more ways than just adding the logo to the side of the buttons, which we certainly want to do ▷.

RalfJung commented 3 years ago

Okay, I'll merge then. :) Thanks @rlepigre for seeing this through!

This means we have a logo. :D