search

logseq / db-test

Used for Database version test
5 stars 1 forks source link

Can create graphs with `/` in name #109

Closed nckre closed 1 month ago

nckre commented 1 month ago

Search first

What Happened?

When trying to create a graph with special symbols (e.g. #) an error message shows up showing all forbidden characters.

CleanShot 2024-09-19 at 10 48 26@2x

However, can create graphs with forward slash (only symbol that worked from the list):

CleanShot 2024-09-19 at 10 49 38@2x

Reproduce the Bug

  1. Go to Create new db graph
  2. Create graph with forward slash in name (e.g. test/test)

Expected Behavior

Either remove / from list of forbidden characters or block creation of graphs with forward slash in name

Screenshots

CleanShot 2024-09-19 at 10 46 51

Browser, Desktop or Mobile Platform Information

No response

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

nckre commented 1 month ago

Seems like / is automatically renamed to _ but still shows up in the graph name:

CleanShot 2024-09-19 at 11 11 39@2x

tiensonqin commented 1 month ago

Fixed by https://github.com/logseq/logseq/commit/5da1e920bf96a7c3898a70d5c19f796639b2ef77.