search

logseq / db-test

Used for Database version test
5 stars 1 forks source link

Page and Tag with same name defaults to using Page instead of Tag #2

Closed Siferiax closed 1 month ago

Siferiax commented 1 month ago

Search first

What Happened?

When both a page and a tag exists with the same name, writing #name results in it getting changed to [[name]] instead of adding the tag to the line.

Reproduce the Bug

  1. Create a page with the name test
  2. Create a tag with the name test
  3. Write a line in the journal: Adding the tag #test
  4. The line gets changed to Adding the tag [[test]]

Expected Behavior

When using #test it should add test as a tag. When using [[test]] it should add test as a page link.

Screenshots

No response

Browser, Desktop or Mobile Platform Information

Brave browser DB version of Logseq at https://test.logseq.com/

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

logseqramses commented 1 month ago

I can reproduce the issue. The Tag only appears when you hit Enter; if you type the tag name all out and click out of the block it will instead turn into a [[page reference]]:

https://github.com/user-attachments/assets/51303853-9666-4e21-ab27-0a2660eccdcf

Siferiax commented 1 month ago

https://github.com/user-attachments/assets/08dcaa21-7f32-4aaa-8e78-e7ffaf11f2d9

Actually I see the same behavior regardless of input type.

tiensonqin commented 1 month ago

Thanks for the report, I can reproduce the bug. I'll push a fix soon.

tiensonqin commented 1 month ago

@Siferiax @logseqramses I just pushed a fix, let me know whether it works for you.

logseqramses commented 1 month ago

@tiensonqin There's no difference for me. If I don't hit Enter, the tag is still turned into a page reference:

https://github.com/user-attachments/assets/ba64050f-2de1-4cff-935d-3e0321cc9ef5

Console log:

zotero.js:332 Service worker (re)started at 2024-08-14 13:06:00 at chrome-extension://ekhagklcjbdpajgpjgmbionohlpdbjgc/zotero.js:314
(anonymous) @ zotero.js:332
debug.js:87 (3)(+0000000): Setting debug.store to false

debug.js:87 (3)(+0000021): Translators: Saved 725 translators.

debug.js:87 (3)(+0000000): Repo: Next check in 13503.374s

debug.js:87 (3)(+0000000): HTTP POST http://127.0.0.1:23119/connector/proxies

debug.js:87 (3)(+0000000): HTTP GET chrome-extension://ekhagklcjbdpajgpjgmbionohlpdbjgc/utilities/resource/dateFormats.json

debug.js:87 (3)(+0000001): Error: HTTP request to http://127.0.0.1:23119/connector/proxies rejected with status 0

debug.js:87 (3)(+0000001): Setting lastVersion to "5.0.142"

debug.js:87 (3)(+0000000): Connector_Browser: onFrameLoaded for https://test.logseq.com/#/; https://test.logseq.com/#/

debug.js:87 (3)(+0000050): HTTP GET chrome-extension://ekhagklcjbdpajgpjgmbionohlpdbjgc/utilities/resource/dateFormats.json

core.cljs:200 restore-tokens-from-localstorage
buffers.cljs:140 
    Welcome to Logseq!
    If you encounter any problem, feel free to file an issue on GitHub (https://github.com/logseq/logseq)
    or join our forum (https://discuss.logseq.com).
    .____
    |    |    ____   ____  ______ ____  ______
    |    |   /  _ \ / ___\/  ___// __ \/ ____/
    |    |__(  <_> ) /_/  >___ \\  ___< <_|  |
    |_______ \____/\___  /____  >\___  >__   |
            \/    /_____/     \/     \/   |__|

debug.js:87 (3)(+0000997): Translators: Looking for translators for https://test.logseq.com/#/

debug.js:87 (3)(+0000022): HTTP GET chrome-extension://ekhagklcjbdpajgpjgmbionohlpdbjgc/utilities/resource/dateFormats.json

debug.js:87 (4)(+0000020): Translate: Binding sandbox to https://test.logseq.com/#/

debug.js:87 (4)(+0000002): Translate: Parsing code for unAPI (e7e01cac-1e37-4da6-b078-a0e8343b0e98, 2019-07-15 19:40:00)

debug.js:87 (4)(+0000002): Translate: Parsing code for COinS (05d07af9-105a-4572-99f6-a8e231c0daef, 2021-06-03 14:25:00)

debug.js:87 (4)(+0000005): Translate: Parsing code for Embedded Metadata (951c027d-74ac-47d4-a107-9c3069ab7b48, 2024-06-14 04:50:00)

debug.js:87 (3)(+0000000): Translate: Embedded Metadata: found 20 meta tags

debug.js:87 (3)(+0000000): Translate: Creating translate instance of type import in sandbox

debug.js:87 (4)(+0000002): Translate: Binding sandbox to https://test.logseq.com/#/

debug.js:87 (4)(+0000002): Translate: Parsing code for RDF (5e3ad958-ac79-463d-812b-a86a9235c28f, 2023-05-20 18:20:00)

debug.js:87 (3)(+0000000): Translate: Initializing RDF data store

debug.js:87 (4)(+0000002): Translate: Parsing code for DOI (c159dcfe-8a53-4301-a499-30f6549c340d, 2024-05-17 20:25:00)

debug.js:87 (3)(+0000000): Translate: All translator detect calls and RPC calls complete:

debug.js:87 (3)(+0000000):  Embedded Metadata: 320

debug.js:87 (5)(+0000000): Translate: Running handler 0 for translators

debug.js:87 (5)(+0000000): Translate: Running handler 1 for translators

sqlite3-bundler-friendly.mjs:11350 Ignoring inability to install OPFS sqlite3_vfs: Cannot install OPFS: Missing SharedArrayBuffer and/or Atomics. The server must emit the COOP/COEP response headers to enable those. See https://sqlite.org/wasm/doc/trunk/persistence.md#coop-coep
(anonymous) @ sqlite3-bundler-friendly.mjs:11350
Show 1 more frame
Show less
browser.cljs:62 Storage will not be cleared unless from explicit user action
core.cljs:200 :listen-db-changes! (:sync-db-to-main-thread :gen-asset-change-events :gen-rtc-ops :gen-undo-ops)
core.cljs:200 :frontend.db.restore/restore-graph! loads 806 datoms in 53 ms
handler.cljs:147 db restored, setting up repo hooks
debug.js:87 (3)(+0070479): Connector_Browser: onActivated for https://github.com/logseq/db-test/issues/2

debug.js:87 (3)(+0041558): Connector_Browser: onActivated for https://test.logseq.com/#/

debug.js:87 (3)(+0067274): Connector_Browser: onActivated for https://github.com/logseq/db-test/issues/2

debug.js:87 (3)(+0045835): Connector_Browser: onActivated for https://test.logseq.com/#/

debug.js:87 (3)(+0042093): Connector_Browser: onActivated for 

debug.js:87 (3)(+0001058): Connector_Browser: onFrameLoaded for https://help.figma.com/hc/en-us/articles/360041949073-Export-network-logs; https://help.figma.com/hc/en-us/articles/360041949073-Export-network-logs

debug.js:87 (3)(+0000118): HTTP GET chrome-extension://ekhagklcjbdpajgpjgmbionohlpdbjgc/utilities/resource/dateFormats.json

debug.js:87 (3)(+0001176): Translators: Looking for translators for https://help.figma.com/hc/en-us/articles/360041949073-Export-network-logs

debug.js:87 (3)(+0000017): HTTP GET chrome-extension://ekhagklcjbdpajgpjgmbionohlpdbjgc/utilities/resource/dateFormats.json

debug.js:87 (4)(+0000002): Translate: Binding sandbox to https://help.figma.com/hc/en-us/articles/360041949073-Export-network-logs

debug.js:87 (4)(+0000002): Translate: Parsing code for unAPI (e7e01cac-1e37-4da6-b078-a0e8343b0e98, 2019-07-15 19:40:00)

debug.js:87 (4)(+0000002): Translate: Parsing code for COinS (05d07af9-105a-4572-99f6-a8e231c0daef, 2021-06-03 14:25:00)

debug.js:87 (4)(+0000004): Translate: Parsing code for Embedded Metadata (951c027d-74ac-47d4-a107-9c3069ab7b48, 2024-06-14 04:50:00)

debug.js:87 (3)(+0000001): Translate: Embedded Metadata: found 9 meta tags

debug.js:87 (3)(+0000000): Translate: Creating translate instance of type import in sandbox

debug.js:87 (4)(+0000002): Translate: Binding sandbox to https://help.figma.com/hc/en-us/articles/360041949073-Export-network-logs

debug.js:87 (4)(+0000003): Translate: Parsing code for RDF (5e3ad958-ac79-463d-812b-a86a9235c28f, 2023-05-20 18:20:00)

debug.js:87 (3)(+0000000): Translate: Initializing RDF data store

debug.js:87 (4)(+0000003): Translate: Parsing code for DOI (c159dcfe-8a53-4301-a499-30f6549c340d, 2024-05-17 20:25:00)

debug.js:87 (3)(+0000000): Translate: All translator detect calls and RPC calls complete:

debug.js:87 (3)(+0000000):  Embedded Metadata: 320

debug.js:87 (5)(+0000000): Translate: Running handler 0 for translators

debug.js:87 (5)(+0000000): Translate: Running handler 1 for translators

debug.js:87 (3)(+0006209): Connector_Browser: onActivated for https://www.youtube.com/watch?v=nFjq01JHjkM

debug.js:87 (3)(+0000001): Connector_Browser: onActivated for https://test.logseq.com/#/
tiensonqin commented 1 month ago

@logseqramses That's the expected behavior for now. However, if we decide to bring inline tags back, this will change. I'll close this issue.

logseqramses commented 1 month ago

@tiensonqin :

That's the expected behavior for now.

So we still have two behaviors for the same syntax? Based on whether you hit enter or you click out of the block, it has one behavior (turn syntax into a Tag) or another (turn syntax into a page reference)?

That is very confusing, especially as there is no hint in the UI that this behavior exist. If we do not make this consistent to one behavior, I predict we will get many more bug reports like this.

Siferiax commented 1 month ago

Can at least confirm that pressing enter now actually adds the tag instead of the page reference.