logseq / logseq

A privacy-first, open-source platform for knowledge management and collaboration. Download link: http://github.com/logseq/logseq/releases. roadmap: http://trello.com/b/8txSM12G/roadmap
https://logseq.com
GNU Affero General Public License v3.0
31.26k stars 1.82k forks source link

Config.edn :hidden does not prevent files being indexed #8822

Open DanBennettDev opened 1 year ago

DanBennettDev commented 1 year ago

Search first

What Happened?

Logseq is not ignoring files in my hidden folders

in config.edn

 ;; The app will ignore those directories or files.
 ;; E.g. :hidden ["/archived" "/test.md" "../assets/archived"]
 :hidden ["../rubbish", "../Rubbish", "/Rubbish", "/rubbish"]

But on loading the app each time I get conflict warnings: e.g.

Page already exists with another file: [LOCATION]/LogSeq/pages/Boundary Objects, Epistemology, Coordination.md, current file: [LOCATION]/LogSeq/Rubbish/2023-03-05/Boundary Objects, Epistemology, Coordination.md. Please keep only one of them and re-index your graph.

Reproduce the Bug

  1. set config.edn as follows

    ;; The app will ignore those directories or files.
    ;; E.g. :hidden ["/archived" "/test.md" "../assets/archived"]
    :hidden ["../rubbish", "../Rubbish", "/Rubbish", "/rubbish"]
  2. copy a .md file from ... LogSeq/pages to ... LogSeq/Rubbish

  3. reload or reindex logseq

  4. see error message

Expected Behavior

Files in the folders listed under :hidden should not be indexed

Screenshots

No response

Desktop or Mobile Platform Information

Windows 10, Desktop app 0.8017

Additional Context

the ./Rubbish folder is a windows hidden folder

Are you willing to submit a PR? If you know how to fix the bug.

I don't know how to fix the bug

andelf commented 1 year ago

remove-hidden-files should be added to both fs watcher and init .

I'll fix this by the next release.

chrismit3s commented 1 year ago

Are globs allowed in the :hidden setting? Would be pretty nice to hide the automatically generated hls___* files you get from annotating a pdf.

boydkelly commented 1 year ago

Runnning into this issue as well on 0.9.6 on linux. Every time Logseq starts up or reindexes I get error messages for each file.

I have in my config.edn: :hidden ["/files/" "../files/" ]

But where is the actual root here? Parallel to the pages/logseq/journals directories right?

Screenshot from 2023-05-18 20-03-25

cliffordx commented 1 year ago

I hope this issue will be fix soon.

boydkelly commented 1 year ago

remove-hidden-files should be added to both fs watcher and init .

I'll fix this by the next release.

Still getting this error on 0.9.9....

Thanks!!!

geoffadams commented 1 year ago

Also seeing this with versions 0.9.8 and 0.9.10, on both Mac (Apple Silicon) and Android.

What appears to happen is that a manually initiated re-index in the UI will obey the :hidden paths, but the automatic re-index upon application start does not. So long as you don't exit the application then the "hidden" files stay hidden. As soon as you fully close the app and then re-open it, you get the issue all over again.

zhaochunqi commented 11 months ago

Also seeing this with versions 0.9.8 and 0.9.10, on both Mac (Apple Silicon) and Android.

What appears to happen is that a manually initiated re-index in the UI will obey the :hidden paths, but the automatic re-index upon application start does not. So long as you don't exit the application then the "hidden" files stay hidden. As soon as you fully close the app and then re-open it, you get the issue all over again.

Same with version v0.9.14 .

DiamondYuan commented 3 months ago

Same with version 0.10.8

boydkelly commented 3 months ago

Super obnoxious. Its a deal breaker for me.

On Mon, Apr 1, 2024, 10:10 DiamondYuan @.***> wrote:

Same with version 0.10.8

— Reply to this email directly, view it on GitHub https://github.com/logseq/logseq/issues/8822#issuecomment-2030175029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2BH3BFKG5IX23S225FAYDY3GIIVAVCNFSM6AAAAAAV2K6HS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGE3TKMBSHE . You are receiving this because you commented.Message ID: @.***>

promicrobial commented 2 months ago

I am also having similar issues with Logseq 0.10.9 on Linux. For now I've just moved these files.

boydkelly commented 2 months ago

I hope this issue will be fix soon.

Yeah its been a year!

DanBennettDev commented 1 month ago

This seemed to be fixed for a version, but it's happening in the current version.

I load the app, see a pile of error messages. Then I see that the query of upcoming projects (which is at the centre of my workflow) is wrong, because there are loads of files from the sync tool's rubbish folder in there. So I have to load, reindex, sometimes reload the app before I can see my upcoming work correctly presented. It totally interrupts the flow of thoughts. That's a pretty frustrating flaw in an app designed for self organisation and helping people sink into their work. I am at the point of looking for alternatives, and I'm only stopped by inertia of existing notes. But the balance of frustration vs effort required to move is going to tip at some point and lots of users will be the same. Or they'll be moaning about jank on forums.

boydkelly commented 1 month ago

I love logseq for many reasons but i have now totally migrated to obsidian because of this issue. Could this be such a technical hurdle?