logseq / marketplace

A centralized packages manager for Logseq marketplace plugins.

MIT License

253 stars 282 forks source link

Add logseq-chess #420

Closed r8 closed 1 year ago

r8 commented 1 year ago

Submit a new Plugin to Marketplace

Plugin Github repo URL:

Github releases checklist

[x] a legal package.json file.
[x] a valid CI workflow build action for Github releases. (Optional for theme plugin only).
[x] a release which includes a release zip pkg from a successful build.
[x] a clear README file, ideally with an image or gif showcase. (For more friendly to users, it is recommended to have English version description).
[x] a license in the LICENSE file.

xyhp915 commented 1 year ago

Hi @r8 Interesting plugin! I found this plugin missing a release zip pkg from the GitHub releases list. It looks like this plugin zip package CleanShot 2023-07-11 at 10 40 58@2x

r8 commented 1 year ago

Hi @xyhp915 My bad, missed that.

Meanwhile I've found another issue. I've installed your plugin logseq-fenced-code-plus, and it looks like there's some kind of conflict.

If logseq-fenced-code-plus is enabled, then logseq-chess doesn't work. If I disable logseq-fenced-code-plus, then my logseq-chessrenders successfully. But if I'll enable logseq-fenced-code-plus after that, then logseq-fenced-code-plus doesn't work. It seems "There can be only one" :(

Any chance I've misunderstood something in how API works and there's a quick fix?

r8 commented 1 year ago

@xyhp915 I've fixed the upload of zip

Bad3r commented 1 year ago

Plugin repo: https://github.com/r8/logseq-chess

xyhp915 commented 1 year ago

Hi @xyhp915 My bad, missed that.

Meanwhile I've found another issue. I've installed your plugin logseq-fenced-code-plus, and it looks like there's some kind of conflict.

If logseq-fenced-code-plus is enabled, then logseq-chess doesn't work. If I disable logseq-fenced-code-plus, then my logseq-chessrenders successfully. But if I'll enable logseq-fenced-code-plus after that, then logseq-fenced-code-plus doesn't work. It seems "There can be only one" :(

Any chance I've misunderstood something in how API works and there's a quick fix?

Thanks for your report! I will test it soon :)

xyhp915 commented 1 year ago

Hi @r8 I found that is a bug. A quick fix is here https://github.com/logseq/logseq/pull/9847

r8 commented 1 year ago

@xyhp915 You're a star :)

r8 commented 1 year ago

Was it closed by mistake? Or should I create a new pull request?

xyhp915 commented 1 year ago

Was it closed by mistake? Or should I create a new pull request?

It's a mistake :) This PR will be merged when the next version of Logseq is released.