Closed cldwalker closed 2 years ago
@RCmerci Thanks for the fix! Confirmed this works with a local build of master
Fyi, I did a roundtrip on 300+ pages and now I only see one minor data loss bug and the rest are just changes in syntax with functionality preserved. Here are the changes in syntax in case it's interesting:
|---|---|
Hi @tiensonqin. When I use Mldoc's
astExportMarkdown
from js (via nbb), I noticed that blocks with only one property do not export their property drawer. Blocks with 2 or more properties export their property drawer fine. I think this is a bug as export should not lose property information. To reproduce, you can use the logseq-roundtrip script which converts markdown file to ast and then exports ast to markdown file. Steps to reproducegit clone https://github.com/cldwalker/nbb-clis && cd nbb-clis
curl https://raw.githubusercontent.com/cldwalker/nbb-clis/main/test/resources/advanced.md -o advanced.md
bin/logseq-roundtrip advanced.md advanced-roundtrip.md
collapsed:: true
while the banana node exports its propertiesI suspect https://github.com/logseq/mldoc/commit/9aed290e22008adec391528eee64e3305631bb36#r63959759 is the source of the bug but I don't know ocaml