search

logseq / mldoc

Another Emacs Org-mode and Markdown parser.
GNU Affero General Public License v3.0
233 stars 20 forks source link

fix: inline entity separators #130

Closed TheLostLambda closed 1 year ago

TheLostLambda commented 1 year ago

This aims to address a long-standing gripe I have when using Logseq!

In Emacs's org-mode, {} can be used to separate items like \Delta from any text that follows. This is consistent with how {} is used to explicitly mark where sub/superscripts end. Here are some examples from Emacs that I've converted into test cases:

This: image

Becomes: image

One way I've continued to deviate from this Emacs behavior is by transforming \DeltaG into DeltaG (without the backslash). This keeps the same behavior that already existed and seems to fit a bit better with the way Logseq displays things?

I'm happy to change that too!

(Also, sorry if I'm made some simple mistakes in this short PR, today is the first time I've ever read / written OCaml code and I'm working off of a familiarity with Haskell!)

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

TheLostLambda commented 1 year ago

I'm not sure who all has review permissions for this repo, but I'll tag @tiensonqin for now! :)

TheLostLambda commented 1 year ago

Might also tag @RCmerci just in case they have a bit more time!