search

logseq / nbb-logseq

nbb with features enabled for logseq
MIT License
141 stars 3 forks source link

Added some cljs-time functions #3

Closed dom8509 closed 2 years ago

dom8509 commented 2 years ago
logseq-cldwalker commented 2 years ago

Hi. Thanks for contributing. As mentioned in the readme, we'd prefer discussion first for contributions. What are you looking to do by extending time namespaces?

dom8509 commented 2 years ago

Hello and sorry, next time I will add a discussion first:) I created a script based on nbb-logseq to export my logseq graph to markdown. To create my markdown metadata, I needed the methods I added to the namespace.
See: https://github.com/dom8509/logseq-to-markdown/blob/main/src/logseq_to_markdown/utils.cljs I also tried to add them to deps.edn for my own cljs-time version, but nbb-logseq always used the methods of the cljs-time package inside nbb-logseq.

I have already created my own version of nbb-logseq that I use in my code, but I thought it might be useful to you as well. If I am using the cljs-time component of nbb-logseq incorrectly and there is another way to extend and use the time functions without adding them to the nbb-logseq namespace, please let me know.

logseq-cldwalker commented 2 years ago

No worries. Cool to see you're using nbb-logseq for publishing efforts

I have already created my own version of nbb-logseq that I use in my code, but I thought it might be useful to you as well. If I am using the cljs-time component of nbb-logseq incorrectly and there is another way to extend and use the time functions without adding them to the nbb-logseq namespace, please let me know.

Unfortunately for libraries that come bundled with nbb-logseq (which are few), adding them through sci is the only way. This PR is reasonably small and we'd love to encourage publishing efforts in nbb-logseq

logseq-cldwalker commented 2 years ago

0.7.135 has been released with these changes