search

logseq / publish-spa

A github action and CLI to publish logseq graphs as a SPA app
MIT License
233 stars 15 forks source link

slide feature doesn't work when published on urls with a non "/" path #11

Closed trylks closed 10 months ago

trylks commented 1 year ago

After exporting my graph, e.g. here, there are several things missing, most notably:

  1. The presentation feature does not work. It is searching for Reveal.js:
  2. The Logseq - Diagrams as Code plugin does not work in this context. I do not even see an error searching for the corresponding JavaScript. I guess I should either:
    • Install the plugin locally and upload it to my GitHub repo (bullets), or
    • Specify in some configuration files the plugins to install so that Publish SPA will install them at build time. This would be great, but I could not find the corresponding documentation.

Am I missing something?

PD: This question is related to another question at the Logseq - Diagrams as Code repo.

logseq-cldwalker commented 1 year ago

Hi. For plugins, they only work on desktop. If you'd like plugin support for web (and publishing apps), I'd recommend opening a feature request as was done for mobile.

For the presentation/slide feature, it looks like it's an issue specific to paths that aren't "/" e.g. "bullets/" with your graph. You can see slides working at https://docs.logseq.com/#/page/contents. This isn't a high priority bug for us currently so contributions welcome in the meantime

trylks commented 1 year ago

Plugins: will do.

Presentation: Is this replace the problem?

logseq-cldwalker commented 1 year ago

Possibly. Pull request welcome if it works for you

On Mon, 7 Aug 2023 at 14:44, trylks @.***> wrote:

Plugins: will do.

Presentation: Is this replace https://github.com/logseq/logseq/blob/62eb86f0c87275333279613171c76bc45f65421b/src/main/frontend/handler/assets.cljs#L57 the problem?

— Reply to this email directly, view it on GitHub https://github.com/logseq/publish-spa/issues/11#issuecomment-1668408298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXFVC546T36EJNQ4VLJTAH3XUEZSJANCNFSM6AAAAAA24WOU44 . You are receiving this because you commented.Message ID: @.***>

logseq-cldwalker commented 10 months ago

@trylks Hi. If you update to the latest publish-spa version, 0.3.0 and configure the version option to 7525689bfb87009c752916e6a395dac6c64d11a6, slides should work on your logseq graph