PDF Support on published graphs

daviddavo commented 6 months ago

Currently, published graphs that link a PDF don't work. Not only you can't use the built-in logseq viewer, you can't even download the PDF (without editing the URL or using your browser's developer tools). It's as if the link is broken.

An easy meantime patch could be just linking the PDF so it works in the browser or it downloads the file, even if highlighting and notes don't work.

As @LuciferianInk said:

I understand that in-page PDF highlighting and such may be difficult to support in the exported web app, currently, but it would be VERY nice if there was still a link, for my users to click. As it is, the PDF link is simply stripped from the export, leaving a bunch of pages where PDF content is referenced, but there's no actual PDF to look at.

To Reproduce

Steps to reproduce the behavior (from original post logseq/logseq#4048):

Add a PDF to your logseq graph
Export the graph as standalone HTML
Open the standalone HTML
Try opening the PDF

Workaround

From @acsr post

Manually change the Link in the Markdown source of the page into a file asset: Remove the leading ! and replace the two dots starting the go-one-up asset link with a same level file link prefix [Filename-of-the-pdf-as-text.pdf](file://./assets/Filename-of-the-pdf-as-text.pdf)

For me the PDF now shows up in a new tab using the default PDF viewer of the browser (for me: inside a new Chrome tab), when the PDF is already in the assets folder. But it is not exported there automatically anymore!

Solution to finalize the workaround
Do not remove the default PDF asset ![Name.pdf](../assets/Name.pdf) Link in the MD
Add an aditional Display link [Name.pdf](file://./assets/Name.pdf) just after the regular PDF asset link This exports the PDF into assets, works as usual in the Logseq app but adds at least link access to the asset!

Poor but better than nothing.

Note

This is a duplicate of logseq/logseq#4048

acsr commented 6 months ago

I tested the export in publish-spa (with a 0.9.18 static build) with same issue and my workaround doing the basic job.

publish-spa main was hopefully updated to 0.3.0 by pulling main and running just yarn install, but logs no changes. Need to lookup if updating needs another command. (updating procedure is not mentioned in the README.md yet)

Now I want to update the static build to 0.10.x first and then investigate publish-spa deeper.

filiptrplan commented 4 months ago

Is there any update on this? Would be great to have PDFs linked in the published page.

Is the team at least considering this issue?

logseq / publish-spa